Skip to content

buffer: Preallocate array with buffer length in Buffer#toJSON #11733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alemures wants to merge 1 commit into from
Closed

buffer: Preallocate array with buffer length in Buffer#toJSON #11733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Preallocate array with buffer length 
subsystem: buffer

Because the final array length is known, it's better to allocate its
final length at initialization time to avoid future reallocations.

It also adds an explicit buffer length greater than 0 comparison so
it's more readable, avoids the internal ToBoolean call and follows the
standard Node.js API format (as it can be checked in other similar
structures where 'length > 0' is preferred over 'length')
  • Loading branch information
@alemures
alemures committed Mar 13, 2017
commit 2fd45da1fce902a105327c2c591f411a524e932a
4 changes: 2 additions & 2 deletions lib/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,8 +810,8 @@ Buffer.prototype.write = function(string, offset, length, encoding) {


Buffer.prototype.toJSON = function() {
if (this.length) {
const data = [];
if (this.length > 0) {
const data = new Array(this.length);
for (var i = 0; i < this.length; ++i)
data[i] = this[i];
return { type: 'Buffer', data };
Expand Down