Skip to content

crypto: add sign/verify support for RSASSA-PSS #11705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 17 commits into from
Closed

crypto: add sign/verify support for RSASSA-PSS #11705

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a361f53
crypto: add sign/verify support for RSASSA-PSS
tniessen Mar 5, 2017
e467227
Various improvements related to PR #11705
tniessen Mar 7, 2017
5a874a5
Minor linting fixes
tniessen Mar 7, 2017
8a23882
Fix API description, error message
tniessen Mar 8, 2017
15abaae
Use defined constants instead of values
tniessen Mar 8, 2017
d75601e
Improvements requested by sam-github
tniessen Mar 8, 2017
5e78d9c
Changes requested by bnoordhuis
tniessen Mar 11, 2017
5e5f2e4
Move application of RSA options out of sign/verify
tniessen Mar 14, 2017
b9a6779
Fix linter error
tniessen Mar 14, 2017
fcd7053
Move RSA option parsing to crypto.js
tniessen Mar 14, 2017
287e2d6
Remove unused using
tniessen Mar 14, 2017
8dc383e
Strict checks and more tests
tniessen Mar 15, 2017
1679e0c
Fix linting
tniessen Mar 15, 2017
8b64c04
Minor improvements
tniessen Mar 16, 2017
44b71e9
Note about MGF1, test vectors
tniessen Mar 17, 2017
4f695aa
Add RSASSA-PSS sign test
tniessen Mar 28, 2017
8772278
Add changes to doc
tniessen Apr 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix linting
  • Loading branch information
@tniessen
tniessen committed Mar 26, 2017
commit 1679e0c6875c01b363d7e496bb5e59cd268f2584
28 changes: 14 additions & 14 deletions test/parallel/test-crypto-sign-verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ const modSize = 1024;
{
function testPSS(algo, hLen) {
// Maximum permissible salt length
let max = modSize / 8 - hLen - 2;
const max = modSize / 8 - hLen - 2;

function getEffectiveSaltLength(saltLength) {
switch(saltLength) {
switch (saltLength) {
case crypto.constants.RSA_PSS_SALTLEN_DIGEST:
return hLen;
case crypto.constants.RSA_PSS_SALTLEN_MAX_SIGN:
Expand All @@ -89,32 +89,32 @@ const modSize = 1024;
}
}

let signSaltLengths = [
const signSaltLengths = [
crypto.constants.RSA_PSS_SALTLEN_DIGEST,
getEffectiveSaltLength(crypto.constants.RSA_PSS_SALTLEN_DIGEST),
crypto.constants.RSA_PSS_SALTLEN_MAX_SIGN,
getEffectiveSaltLength(crypto.constants.RSA_PSS_SALTLEN_MAX_SIGN),
0, 16, 32, 64, 128
];

let verifySaltLengths = [
const verifySaltLengths = [
crypto.constants.RSA_PSS_SALTLEN_DIGEST,
getEffectiveSaltLength(crypto.constants.RSA_PSS_SALTLEN_DIGEST),
getEffectiveSaltLength(crypto.constants.RSA_PSS_SALTLEN_MAX_SIGN),
0, 16, 32, 64, 128
];

signSaltLengths.forEach((signSaltLength) => {
if(signSaltLength > max) {
if (signSaltLength > max) {
// If the salt length is too big, an Error should be thrown
assert.throws(() => {
crypto.createSign(algo)
.update('Test123')
.sign({
key: keyPem,
padding: crypto.constants.RSA_PKCS1_PSS_PADDING,
saltLength: signSaltLength
});
.update('Test123')
.sign({
key: keyPem,
padding: crypto.constants.RSA_PKCS1_PSS_PADDING,
saltLength: signSaltLength
});
}, /^Error:.*data too large for key size$/);
} else {
// Otherwise, a valid signature should be generated
Expand All @@ -137,8 +137,8 @@ const modSize = 1024;
padding: crypto.constants.RSA_PKCS1_PSS_PADDING,
saltLength: verifySaltLength
}, s4);
let saltLengthCorrect = getEffectiveSaltLength(signSaltLength) ==
getEffectiveSaltLength(verifySaltLength);
const saltLengthCorrect = getEffectiveSaltLength(signSaltLength) ==
getEffectiveSaltLength(verifySaltLength);
assert.strictEqual(verified, saltLengthCorrect, 'verify (PSS)');
});

Expand Down Expand Up @@ -171,7 +171,7 @@ const modSize = 1024;

// Test exceptions for invalid `padding` and `saltLength` values
{
[null, undefined, NaN, "boom", {}, []].forEach((invalidValue) => {
[null, undefined, NaN, 'boom', {}, []].forEach((invalidValue) => {
assert.throws(() => {
crypto.createSign('RSA-SHA256')
.update('Test123')
Expand Down