Skip to content

test: skip tests with common.skip #11585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thefourtheye wants to merge 1 commit into from
Closed

test: skip tests with common.skip #11585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: skip tests with common.skip 
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.
  • Loading branch information
@thefourtheye
thefourtheye committed Feb 27, 2017
commit eaed633245db37338c6b858ed95d36fbecf44fb5
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-authenticated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ for (const i in TEST_CASES) {
}

if (common.hasFipsCrypto && test.iv.length < 24) {
console.log('1..0 # Skipped: IV len < 12 bytes unsupported in FIPS mode');
common.skip('IV len < 12 bytes unsupported in FIPS mode');
continue;
}

Expand Down
6 changes: 2 additions & 4 deletions test/parallel/test-tls-empty-sni-context.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
const common = require('../common');

if (!process.features.tls_sni) {
console.log('1..0 # Skipped: node compiled without OpenSSL or ' +
'with old OpenSSL version.');
common.skip('node compiled without OpenSSL or with old OpenSSL version.');
return;
}

const assert = require('assert');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
return;
return common.skip('missing crypto');
}

const tls = require('tls');
Expand Down