Skip to content

lib: avoid using Array.prototype.forEach #11582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 11 commits into from
Closed

lib: avoid using Array.prototype.forEach #11582

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2c00ce
benchmark: benchmark comparing forEach with for
jasnell Feb 26, 2017
4d0d400
stream: avoid using forEach
jasnell Feb 26, 2017
a2d8baa
tls: avoid using forEach
jasnell Feb 26, 2017
ebe8926
fs: avoid using forEach
jasnell Feb 26, 2017
36dc38a
lib: avoid using forEach in LazyTransform
jasnell Feb 27, 2017
abdd6c6
net: avoid using forEach
jasnell Feb 27, 2017
e8738ca
readline: avoid using forEach
jasnell Feb 27, 2017
59d1fd6
repl: avoid using forEach
jasnell Feb 27, 2017
e9e5c0e
module: avoid using forEach
jasnell Feb 27, 2017
2e0cb91
util: avoid using forEach
jasnell Feb 27, 2017
142bf54
lib: avoid using forEach
jasnell Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tls: avoid using forEach
  • Loading branch information
@jasnell
jasnell committed Mar 15, 2017
commit a2d8baad154f214af146a2f5827d357e3336e774
10 changes: 7 additions & 3 deletions lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,12 +321,16 @@ var proxiedMethods = [
];

// Proxy HandleWrap, PipeWrap and TCPWrap methods
proxiedMethods.forEach(function(name) {
tls_wrap.TLSWrap.prototype[name] = function methodProxy(...args) {
function makeMethodProxy(name) {
return function methodProxy(...args) {
Copy link
Copy Markdown
Contributor

@mscdex mscdex Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why ...args is being used when we're just using it with .apply() which should handle arguments just fine.

Copy link
Copy Markdown
Member Author

@jasnell jasnell Mar 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way works for me really

Copy link
Copy Markdown
Contributor

@mscdex mscdex Mar 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would vote for changing to using arguments while we're in here.

if (this._parent[name])
return this._parent[name].apply(this._parent, args);
};
});
}
for (var n = 0; n < proxiedMethods.length; n++) {
tls_wrap.TLSWrap.prototype[proxiedMethods[n]] =
makeMethodProxy(proxiedMethods[n]);
}

tls_wrap.TLSWrap.prototype.close = function close(cb) {
let ssl;
Expand Down