Skip to content

net: prefer === to == #11513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
notarseniy wants to merge 1 commit into from
Closed

net: prefer === to == #11513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
net: prefer === to == 
* Change === to == in one place
* Add explanation about another non-strict if-statement
  • Loading branch information
@notarseniy
notarseniy committed Feb 24, 2017
commit 9209efa5f0891a4720ca4815862dd399fbae0a23
5 changes: 4 additions & 1 deletion lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ function Socket(options) {
} else if (options.fd !== undefined) {
this._handle = createHandle(options.fd);
this._handle.open(options.fd);
// options.fd can be string (since it user-defined),
// so changing this to === would be semver-major
// See: https://github.com/nodejs/node/pull/11513
if ((options.fd == 1 || options.fd == 2) &&
(this._handle instanceof Pipe) &&
process.platform === 'win32') {
Expand Down Expand Up @@ -1069,7 +1072,7 @@ function afterConnect(status, handle, req, readable, writable) {
self.connecting = false;
self._sockname = null;

if (status == 0) {
if (status === 0) {
self.readable = readable;
self.writable = writable;
self._unrefTimer();
Expand Down