Skip to content

src: clean up MaybeStackBuffer usage in i18n #11464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 5 commits into from
Closed

src: clean up MaybeStackBuffer usage in i18n #11464

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62539ca
src: don't assume v8::Local is using-declared
TimothyGu Feb 20, 2017
41786c4
src: clean up MaybeStackBuffer
TimothyGu Feb 20, 2017
199d115
src, i18n: cleanup usage of MaybeStackBuffer
TimothyGu Feb 20, 2017
b5acb67
benchmark: add url.domainTo*()
TimothyGu Feb 20, 2017
0995c12
util: update comments
TimothyGu Feb 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: don't assume v8::Local is using-declared
  • Loading branch information
@TimothyGu
TimothyGu committed Feb 23, 2017
commit 62539cad368987726e41e611450b27b947838e8d
2 changes: 1 addition & 1 deletion src/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ class BufferValue : public MaybeStackBuffer<char> {

#define SPREAD_BUFFER_ARG(val, name) \
CHECK((val)->IsUint8Array()); \
Local<v8::Uint8Array> name = (val).As<v8::Uint8Array>(); \
v8::Local<v8::Uint8Array> name = (val).As<v8::Uint8Array>(); \
v8::ArrayBuffer::Contents name##_c = name->Buffer()->GetContents(); \
const size_t name##_offset = name->ByteOffset(); \
const size_t name##_length = name->ByteLength(); \
Expand Down