Skip to content

test: enhance test-common.js #11433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: enhance test-common.js #11433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: enhance test-common.js 
* refactor test-common.js so that global leak detection does not need to
  be disabled
* add test for common.fail()
  • Loading branch information
@Trott
Trott committed Feb 16, 2017
commit a045e743a0ac2fe8b8da18af482d3152ea0468ce
13 changes: 12 additions & 1 deletion test/parallel/test-common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,25 @@
const common = require('../common');
const assert = require('assert');

common.globalCheck = false;

// test for leaked global detection
global.gc = 42; // Not a valid global unless --expose_gc is set.
assert.deepStrictEqual(common.leakedGlobals(), ['gc']);
delete global.gc;


// common.mustCall() tests
assert.throws(function() {
common.mustCall(function() {}, 'foo');
}, /^TypeError: Invalid expected value: foo$/);

assert.throws(function() {
common.mustCall(function() {}, /foo/);
}, /^TypeError: Invalid expected value: \/foo\/$/);


// common.fail() tests
assert.throws(
() => { common.fail('fhqwhgads'); },
/^AssertionError: fhqwhgads$/
);