Skip to content

test: skip IPv6 test on non-IPv6 systems #11432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: skip IPv6 test on non-IPv6 systems #11432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: skip IPv6 test on non-IPv6 systems 
Until recently, test-dgram-address would fail on IPv6 but still exit
with a successful return code. (It would console.log() the error but not
actually fail.)

Now that the test has been updated such that it will fail the IPv6 part
of the test if there is an error event emitted by the socket, skip the
test on systems not equipped with IPv6.
  • Loading branch information
@Trott
Trott committed Feb 16, 2017
commit 9b0059f7e12af4095ee40829a81393cfa2d28080
2 changes: 1 addition & 1 deletion test/parallel/test-dgram-address.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const dgram = require('dgram');
socket.bind(0, common.localhostIPv4);
}

{
if (common.hasIPv6) {
// IPv6 Test
const socket = dgram.createSocket('udp6');
const localhost = '::1';
Expand Down