Skip to content

Always call callbacks in lib/_http_outgoing.js #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
laino wants to merge 6 commits into from
Closed

Always call callbacks in lib/_http_outgoing.js #1143

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2dd0bc2
Always call callbacks in lib/_http_outgoing.js
Mar 13, 2015
d733196
Make code adhere to io.js style
Mar 14, 2015
8f20ed6
Make jslint pass
Mar 14, 2015
6d4bd06
Change code style in test
Mar 15, 2015
e712b26
Change code style in another test
Mar 15, 2015
10d5da8
Revert to only a debug message for writes to HEAD responses
Mar 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make code adhere to io.js style
  • Loading branch information
Nils Kuhnhenn committed Mar 14, 2015
commit d7331960c56c9e2e0e2ed461ae6069bda585acfc
14 changes: 7 additions & 7 deletions lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,19 @@ function OutgoingMessage() {
this._headers = null;
this._headerNames = {};

var that = this;
var self = this;

// Call remaining callbacks if stream closes prematurely
this.once('close', function(){
if(that.output.length === 0) return;
this.once('close', function() {
if(self.output.length === 0) return;

var err = new Error('stream closed prematurely');

var outputCallbacks = that.outputCallbacks;
var outputCallbacks = self.outputCallbacks;

that.output = [];
that.outputEncodings = [];
that.outputCallbacks = [];
self.output = [];
self.outputEncodings = [];
self.outputCallbacks = [];

for(var i=0; i<outputCallbacks.length; i++){
var callback = outputCallbacks[i];
Expand Down