Skip to content

errors: port internal/buffer errors to internal/errors #11341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bougarfaoui wants to merge 4 commits into from
Closed

errors: port internal/buffer errors to internal/errors #11341

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb0031a
add ERR_UNABlE_TRNSC_BUFF error
Feb 13, 2017
f59cef8
errors: port internal/buffer errors to internal/errors
Feb 13, 2017
871c137
rename ERR_UNABlE_TRNSC_BUFF to ERR_UNABlE_TRANSCODE_BUFFER
Feb 13, 2017
d34ab10
tests updated
Feb 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/internal/buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
'use strict';

const errors = require('internal/errors');

if (!process.binding('config').hasIntl) {
return;
}
Expand All @@ -24,7 +26,7 @@ exports.transcode = function transcode(source, fromEncoding, toEncoding) {
return result;

const code = icu.icuErrName(result);
const err = new Error(`Unable to transcode Buffer [${code}]`);
const err = new errors.Error('ERR_UNABlE_TRNSC_BUFF', code);
Copy link
Copy Markdown
Member

@jasnell jasnell Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type in the code...

Copy link
Copy Markdown
Member

@jasnell jasnell Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be better to fully spell out transcode and buffer

err.code = code;
err.errno = result;
throw err;
Expand Down
1 change: 1 addition & 0 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,4 @@ module.exports = exports = {
// Note: Please try to keep these in alphabetical order
E('ERR_ASSERTION', (msg) => msg);
// Add new errors from here...
E('ERR_UNABlE_TRNSC_BUFF', `Unable to transcode Buffer [%s]`);