Skip to content

test: cover cluster error during dgram socket bind #11295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 1 commit into from
Feb 13, 2017
Merged

test: cover cluster error during dgram socket bind #11295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: cover cluster error during dgram socket bind 
When a non-exclusive dgram socket is bound from a cluster
worker, a handle is requested from the cluster module. This
commit adds coverage for the case where an error occurs while
retrieving the handle.

PR-URL: #11295
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Feb 13, 2017
commit d3be0f88181b4904f5ceddb88043ef589d777c45
29 changes: 29 additions & 0 deletions test/parallel/test-dgram-cluster-bind-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cluster = require('cluster');
const dgram = require('dgram');
const { UV_UNKNOWN } = process.binding('uv');

if (cluster.isMaster) {
cluster.fork();
} else {
// When the socket attempts to bind, it requests a handle from the cluster.
// Force the cluster to send back an error code.
cluster._getServer = function(self, options, callback) {
callback(UV_UNKNOWN);
};

const socket = dgram.createSocket('udp4');

socket.on('error', common.mustCall((err) => {
assert(/^Error: bind UNKNOWN 0.0.0.0$/.test(err.toString()));
process.nextTick(common.mustCall(() => {
assert.strictEqual(socket._bindState, 0); // BIND_STATE_UNBOUND
socket.close();
cluster.worker.disconnect();
}));
}));

socket.bind(common.mustNotCall('Socket should not bind.'));
}