Skip to content

test: add coverage for dgram _createSocketHandle() #11291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 1 commit into from
Feb 13, 2017
Merged

test: add coverage for dgram _createSocketHandle() #11291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: add coverage for dgram _createSocketHandle() 
This commit adds code coverage to _createSocketHandle(), which
the cluster module uses to create dgram sockets.

PR-URL: #11291
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Feb 13, 2017
commit a2fac322d5782a5b1802039ed477f8d4f0db2bdb
39 changes: 39 additions & 0 deletions test/parallel/test-dgram-create-socket-handle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');
const UDP = process.binding('udp_wrap').UDP;
const _createSocketHandle = dgram._createSocketHandle;

// Throws if an "existing fd" is passed in.
assert.throws(() => {
_createSocketHandle(common.localhostIPv4, 0, 'udp4', 42);
}, /^AssertionError: false == true$/);

{
// Create a handle that is not bound.
const handle = _createSocketHandle(null, null, 'udp4');

assert(handle instanceof UDP);
assert.strictEqual(typeof handle.fd, 'number');
assert(handle.fd < 0);
}

{
// Create a bound handle.
const handle = _createSocketHandle(common.localhostIPv4, 0, 'udp4');

assert(handle instanceof UDP);
assert.strictEqual(typeof handle.fd, 'number');

if (!common.isWindows)
assert(handle.fd > 0);
}

{
// Return an error if binding fails.
const err = _createSocketHandle('localhost', 0, 'udp4');

assert.strictEqual(typeof err, 'number');
assert(err < 0);
}