Skip to content

test: refactor test-dgram-setBroadcast.js #11252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjihrig wants to merge 1 commit into from
Closed

test: refactor test-dgram-setBroadcast.js #11252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-dgram-setBroadcast.js 
This test wasn't actually working, as sockets were being closed,
allowing the test to exit before any assertions were actually
run. This commit refactors the test to maintain the same intended
semantics.
  • Loading branch information
@cjihrig
cjihrig committed Feb 9, 2017
commit 81671e9fe33349ca000b7dcb2867b92830d19eff
44 changes: 15 additions & 29 deletions test/parallel/test-dgram-setBroadcast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,36 +4,22 @@ const common = require('../common');
const assert = require('assert');
const dgram = require('dgram');

const setup = () => {
return dgram.createSocket({type: 'udp4', reuseAddr: true});
};
{
// Should throw EBADF if the socket is never bound.
const socket = dgram.createSocket('udp4');

const teardown = (socket) => {
if (socket.close)
socket.close();
};

const runTest = (testCode, expectError) => {
const socket = setup();
const assertion = expectError ? assert.throws : assert.doesNotThrow;
const wrapped = () => { testCode(socket); };
assertion(wrapped, expectError);
teardown(socket);
};
assert.throws(() => {
socket.setBroadcast(true);
}, /^Error: setBroadcast EBADF$/);
}

// Should throw EBADF if socket is never bound.
runTest((socket) => { socket.setBroadcast(true); }, /EBADF/);
{
// Can call setBroadcast() after binding the socket.
const socket = dgram.createSocket('udp4');

// Should not throw if broadcast set to false after binding.
runTest((socket) => {
socket.bind(0, common.localhostIPv4, () => {
socket.setBroadcast(false);
});
});

// Should not throw if broadcast set to true after binding.
runTest((socket) => {
socket.bind(0, common.localhostIPv4, () => {
socket.bind(0, common.mustCall(() => {
socket.setBroadcast(true);
});
});
socket.setBroadcast(false);
socket.close();
}));
}