Skip to content

url: fix surrogate handling in encodeAuth() #11161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 2 commits into from
Closed

url: fix surrogate handling in encodeAuth() #11161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8368389
url: fix surrogate handling in encodeAuth()
TimothyGu Feb 4, 2017
cc46363
querystring, url: factor out common parts
TimothyGu Feb 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
url: fix surrogate handling in encodeAuth()
  • Loading branch information
@TimothyGu
TimothyGu committed Feb 12, 2017
commit 8368389df9e71cb8e586f3fbddfcf6124b1c1642
1 change: 1 addition & 0 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ function encodeAuth(str) {
}
// Surrogate pair
++i;
++lastPos;
var c2;
if (i < str.length)
c2 = str.charCodeAt(i) & 0x3FF;
Expand Down
9 changes: 9 additions & 0 deletions test/parallel/test-url-format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,15 @@ const formatTests = {
protocol: 'file',
pathname: '/home/user',
path: '/home/user'
},

// surrogate in auth
'http://%F0%9F%98%80@www.example.com/': {
href: 'http://%F0%9F%98%80@www.example.com/',
protocol: 'http:',
auth: '\uD83D\uDE00',
hostname: 'www.example.com',
pathname: '/'
}
};
for (const u in formatTests) {
Expand Down