Skip to content

test: improve punycode test coverage #11144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seppevs wants to merge 1 commit into from
Closed

test: improve punycode test coverage #11144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: improve punycode test coverage 
Adds two additional tests for mapDomain function in punycode.js.
When an email address is given to the toASCII() and toUnicode() functions, only the parts before the '@' character should be encoded/decoded.
  • Loading branch information
@seppevs
seppevs committed Feb 3, 2017
commit 3b05c2b5fc4cd150a1fe5f421781e370ce85f712
6 changes: 6 additions & 0 deletions test/parallel/test-punycode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,3 +237,9 @@ assert.strictEqual(punycode.ucs2.encode([0xDC00]), '\uDC00');
assert.strictEqual(punycode.ucs2.encode([0xDC00, 0x61, 0x62]), '\uDC00ab');

assert.strictEqual(errors, 0);

// test map domain
assert.strictEqual(punycode.toASCII('Bücher@日本語.com'),
'Bücher@xn--wgv71a119e.com');
assert.strictEqual(punycode.toUnicode('Bücher@xn--wgv71a119e.com'),
'Bücher@日本語.com');