Skip to content

buffer: stricter argument checking in toString #11120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seishun merged 4 commits into from
Feb 5, 2017
Merged

buffer: stricter argument checking in toString #11120

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c453db
buffer: stricter argument checking in toString
seishun Feb 2, 2017
0635c4a
add test
seishun Feb 2, 2017
2108299
add test for null, check for full error
seishun Feb 2, 2017
d96ed87
fix lint
seishun Feb 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@seishun
seishun committed Feb 2, 2017
commit 0635c4ac4bfcffb13a5cbf809dbf10879a269f7d
3 changes: 3 additions & 0 deletions test/parallel/test-buffer-tostring-range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,6 @@ assert.strictEqual(rangeBuffer.toString('ascii', 0, true), 'a');
assert.strictEqual(rangeBuffer.toString({toString: function() {
return 'ascii';
}}), 'abc');

// try toString() with 0 as the encoding
assert.throws(() => rangeBuffer.toString(0, 1, 2), /Unknown encoding/);
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve the regular expression to something like /^TypeError: Unknown encoding: 0$/.

Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a similar test for null, minimally.

Copy link
Copy Markdown
Member

@joyeecheung joyeecheung Feb 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better include the complete message, like ^TypeError: Unknown encoding: undefined$.