Skip to content

benchmark: simplify URLSearchParams import #11111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 1 commit into from
Closed

benchmark: simplify URLSearchParams import #11111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
benchmark: simplify URLSearchParams import
  • Loading branch information
@TimothyGu
TimothyGu committed Feb 1, 2017
commit 3ac6c2be2fddb0cddcad86bd94bcc570f657497d
2 changes: 1 addition & 1 deletion benchmark/url/url-searchparams-iteration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common.js');
const assert = require('assert');
const URLSearchParams = new (require('url').URL)('a:').searchParams.constructor;
const { URLSearchParams } = require('url');

const bench = common.createBenchmark(main, {
method: ['forEach', 'iterator'],
Expand Down
2 changes: 1 addition & 1 deletion benchmark/url/url-searchparams-parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
const common = require('../common.js');
const URLSearchParams = new (require('url').URL)('a:').searchParams.constructor;
const { URLSearchParams } = require('url');

const inputs = {
noencode: 'foo=bar&baz=quux&xyzzy=thud',
Expand Down
2 changes: 1 addition & 1 deletion benchmark/url/url-searchparams-read.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
const common = require('../common.js');
const URLSearchParams = new (require('url').URL)('a:').searchParams.constructor;
const { URLSearchParams } = require('url');

const bench = common.createBenchmark(main, {
method: ['get', 'getAll', 'has'],
Expand Down
2 changes: 1 addition & 1 deletion benchmark/url/url-searchparams-stringifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common.js');
const Buffer = require('buffer').Buffer;
const URLSearchParams = new (require('url').URL)('a:').searchParams.constructor;
const { URLSearchParams } = require('url');

const inputs = {
noencode: 'foo=bar&baz=quux&xyzzy=thud',
Expand Down