Skip to content

doc: fix and modernize code examples in domain.md #11110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsemozhetbyt wants to merge 4 commits into from
Closed

doc: fix and modernize code examples in domain.md #11110

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6def61
doc: var -> const in domain.md
vsemozhetbyt Feb 1, 2017
fe0e061
doc: concatenations -> templates in domain.md
vsemozhetbyt Feb 1, 2017
41173ec
doc: add missing space in domain.md
vsemozhetbyt Feb 1, 2017
bfef75b
doc: fix variable shadowing in domain.md
vsemozhetbyt Feb 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: concatenations -> templates in domain.md
  • Loading branch information
@vsemozhetbyt
vsemozhetbyt committed Feb 1, 2017
commit fe0e06116f38e9d8b1b7a45798f19999b520417d
6 changes: 3 additions & 3 deletions doc/api/domain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ d.on('error', (er) => {
// Though we've prevented abrupt process restarting, we are leaking
// resources like crazy if this ever happens.
// This is no better than process.on('uncaughtException')!
console.log('error, but oh well', er.message);
console.log(`error, but oh well ${er.message}`);
});
d.run(() => {
require('http').createServer((req, res) => {
Expand Down Expand Up @@ -106,7 +106,7 @@ if (cluster.isMaster) {
const server = require('http').createServer((req, res) => {
const d = domain.create();
d.on('error', (er) => {
console.error('error', er.stack);
console.error(`error ${er.stack}`);

// Note: we're in dangerous territory!
// By definition, something unexpected occurred,
Expand Down Expand Up @@ -135,7 +135,7 @@ if (cluster.isMaster) {
res.end('Oops, there was a problem!\n');
} catch (er2) {
// oh well, not much we can do at this point.
console.error('Error sending 500!', er2.stack);
console.error(`Error sending 500! ${er2.stack}`);
}
});

Expand Down