Skip to content

deps: hide zlib internal symbols #11082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 2 commits into from
Closed

deps: hide zlib internal symbols #11082

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ae7920
deps: hide zlib internal symbols
sam-github Jan 31, 2017
d271bd3
fixup! deps: hide zlib internal symbols
sam-github Feb 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: hide zlib internal symbols 
Use HAVE_HIDDEN when compiling zlib so it's internal symbols
have __attribute__((visibility ("hidden"))).
  • Loading branch information
@sam-github
sam-github committed Jan 31, 2017
commit 1ae79202d0a358e01947ab53b006802896dd13be
3 changes: 3 additions & 0 deletions deps/zlib/zlib.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
'.',
],
},
'defines': [
'HAVE_HIDDEN',
],
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the 'OS!="win"' conditional below. The __attribute__((visibility("hidden"))) doesn't work with Visual Studio (see https://ci.nodejs.org/job/node-compile-windows/6701/label=win-vs2015/consoleFull) and it probably isn't needed anyway because we use deps/zlib/win32/zlib.def to control what is and isn't exported.

Alternatively, if you teach tools/mkssldef.py to generate UNIX linker maps, we can unify the two approaches.

'conditions': [
['OS!="win"', {
'cflags!': [ '-ansi' ],
Expand Down