Skip to content

src: remove unnecessary req_wrap_obj #10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 1 commit into from
Closed

src: remove unnecessary req_wrap_obj #10942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: remove unnecessary req_wrap_obj 
The req_wrap_obj is only used in one place which is setting up the
arguments for the MakeCallback call. Removing it to simplify the code
somewhat.
  • Loading branch information
@danbev
danbev committed Jan 21, 2017
commit ca880307cd7a22af5db5b5299224a8c4d06d6fcc
3 changes: 1 addition & 2 deletions src/connection_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,10 @@ void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req,
writable = uv_is_writable(req->handle) != 0;
}

Local<Object> req_wrap_obj = req_wrap->object();
Local<Value> argv[5] = {
Integer::New(env->isolate(), status),
wrap->object(),
req_wrap_obj,
req_wrap->object(),
Boolean::New(env->isolate(), readable),
Boolean::New(env->isolate(), writable)
};
Expand Down