Skip to content

http: add doc deprecation for private props #10941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscdex merged 4 commits into from
Mar 9, 2017
Merged

http: add doc deprecation for private props #10941

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86996c5
doc: deprecate private http properties
mscdex Mar 6, 2017
940b530
http: use Symbol for outgoing headers
mscdex Mar 6, 2017
b377034
http: support old private properties and function
mscdex Mar 6, 2017
8243ca0
http: reuse existing StorageObject
mscdex Feb 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
http: reuse existing StorageObject 
PR-URL: #10941
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
  • Loading branch information
@mscdex
mscdex committed Mar 9, 2017
commit 8243ca0e0e87b3e114d9ddf2843d1272bc56b053
6 changes: 1 addition & 5 deletions lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ var RE_FIELDS = new RegExp('^(?:Connection|Transfer-Encoding|Content-Length|' +
var RE_CONN_VALUES = /(?:^|\W)close|upgrade(?:$|\W)/ig;
var RE_TE_CHUNKED = common.chunkExpression;

// Used to store headers returned by getHeaders()
function OutgoingHeaders() {}
OutgoingHeaders.prototype = Object.create(null);

var dateCache;
function utcDate() {
if (!dateCache) {
Expand Down Expand Up @@ -510,7 +506,7 @@ OutgoingMessage.prototype.getHeaderNames = function getHeaderNames() {
// Returns a shallow copy of the current outgoing headers.
OutgoingMessage.prototype.getHeaders = function getHeaders() {
const headers = this[outHeadersKey];
const ret = new OutgoingHeaders();
const ret = new StorageObject();
if (headers) {
const keys = Object.keys(headers);
for (var i = 0; i < keys.length; ++i) {
Expand Down