Skip to content

test: improve code in test-domain-multi #10798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edsadr wants to merge 1 commit into from
Closed

test: improve code in test-domain-multi #10798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: improve code in test-domain-multi 
* use common.mustCall to validate functions executions
* use common.fail to control error
* remove unnecessary variables
* remove unnecessary assertions
* remove console.log and console.error
* use arrow functions
  • Loading branch information
@edsadr
edsadr committed Jan 15, 2017
commit e16e26204e26687945d9789dbf950b84cd039dac
45 changes: 11 additions & 34 deletions test/parallel/test-domain-multi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,16 @@
'use strict';
// Tests of multiple domains happening at once.

require('../common');
const assert = require('assert');
const common = require('../common');
const domain = require('domain');

let caughtA = false;
let caughtB = false;
let caughtC = false;

const http = require('http');

const a = domain.create();
a.enter(); // this will be our "root" domain
a.on('error', function(er) {
caughtA = true;
console.log('This should not happen');
throw er;
});

a.on('error', common.fail);

const http = require('http');
const server = http.createServer(function(req, res) {
const server = http.createServer((req, res) => {
// child domain of a.
const b = domain.create();
a.add(b);
Expand All @@ -31,47 +21,34 @@ const server = http.createServer(function(req, res) {
b.add(req);
b.add(res);

b.on('error', function(er) {
caughtB = true;
console.error('Error encountered', er);
b.on('error', common.mustCall((er) => {
if (res) {
res.writeHead(500);
res.end('An error occurred');
}
// res.writeHead(500), res.destroy, etc.
server.close();
});
}));

// XXX this bind should not be necessary.
// the write cb behavior in http/net should use an
// event so that it picks up the domain handling.
res.write('HELLO\n', b.bind(function() {
res.write('HELLO\n', b.bind(() => {
throw new Error('this kills domain B, not A');
}));

}).listen(0, function() {
}).listen(0, () => {
const c = domain.create();
const req = http.get({ host: 'localhost', port: this.address().port });
const req = http.get({ host: 'localhost', port: server.address().port });

// add the request to the C domain
c.add(req);

req.on('response', function(res) {
console.error('got response');
req.on('response', (res) => {
// add the response object to the C domain
c.add(res);
res.pipe(process.stdout);
});

c.on('error', function(er) {
caughtC = true;
console.error('Error on c', er.message);
});
});

process.on('exit', function() {
assert.strictEqual(caughtA, false);
assert.strictEqual(caughtB, true);
assert.strictEqual(caughtC, true);
console.log('ok - Errors went where they were supposed to go');
c.on('error', common.mustCall((er) => { }));
});