Skip to content

test: increase test-crypto.js strictness #10784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

test: increase test-crypto.js strictness #10784

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
563dae9
test: increase test-crypto.js strictness
Trott Jan 13, 2017
0fe7048
squash: undo unrelated lib/tls.js change
Trott Jan 13, 2017
061aa9e
squash
Trott Jan 13, 2017
63bc2b5
squash
Trott Jan 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash
  • Loading branch information
@Trott
Trott committed Jan 13, 2017
commit 061aa9e6672cd52356a7a1d70f9371a70acc51b5
33 changes: 22 additions & 11 deletions test/parallel/test-crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,22 +53,33 @@ assert.throws(function() {
}, /^TypeError: Data must be a string or a buffer$/);


function assertSorted(list) {
// list is sorted and contains no duplicates
assert(list.every(
(val, index, array) => index === array.length - 1 || val < array[index + 1]
));
function validateList(list) {
// The list must not be empty
assert(list.length > 0);

// The list should be sorted.
// Array#sort() modifies the list in place so make a copy.
const sorted = list.slice().sort();
assert.deepStrictEqual(list, sorted);

// Each element should be unique.
assert.strictEqual([...new Set(list)].length, list.length);

// Each element should be a string.
assert(list.every((value) => typeof value === 'string'));
}

// Assume that we have at least AES-128-CBC.
const cryptoCiphers = crypto.getCiphers();
assert(crypto.getCiphers().includes('aes-128-cbc'));
assert(!crypto.getCiphers().includes('AES-128-CBC'));
assertSorted(crypto.getCiphers());
validateList(cryptoCiphers);

// Assume that we have at least AES256-SHA.
const tlsCiphers = tls.getCiphers();
assert(tls.getCiphers().includes('aes256-sha'));
assert(!tls.getCiphers().includes('AES256-SHA'));
assertSorted(tls.getCiphers());
// There should be no capital letters in any element.
assert(tlsCiphers.every((value) => /^[^A-Z]+$/.test(value)));
validateList(tlsCiphers);

// Assert that we have sha and sha1 but not SHA and SHA1.
assert.notStrictEqual(0, crypto.getHashes().length);
Expand All @@ -78,13 +89,13 @@ assert(!crypto.getHashes().includes('SHA1'));
assert(!crypto.getHashes().includes('SHA'));
assert(crypto.getHashes().includes('RSA-SHA1'));
assert(!crypto.getHashes().includes('rsa-sha1'));
assertSorted(crypto.getHashes());
validateList(crypto.getHashes());

// Assume that we have at least secp384r1.
assert.notStrictEqual(0, crypto.getCurves().length);
assert(crypto.getCurves().includes('secp384r1'));
assert(!crypto.getCurves().includes('SECP384R1'));
assertSorted(crypto.getCurves());
validateList(crypto.getCurves());

// Regression tests for #5725: hex input that's not a power of two should
// throw, not assert in C++ land.
Expand Down