Skip to content

test: convert var->const/let in tests #10685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gibfahn merged 2 commits into from
Jan 11, 2017
Merged

test: convert var->const/let in tests #10685

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a0e462
test: use eslint to fix var->const/let
gibfahn Jan 8, 2017
81fef91
tools, test: require const/let in test
gibfahn Jan 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tools, test: require const/let in test 
PR-URL: #10685
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
  • Loading branch information
@gibfahn
gibfahn committed Jan 11, 2017
commit 81fef918d5a8a9aa297b78ade5e58d6caa3176e6
10 changes: 8 additions & 2 deletions test/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
## Test-specific linter rules

rules:
## common module is mandatory in tests
required-modules: [2, common]
# ECMAScript 6
# http://eslint.org/docs/rules/#ecmascript-6
no-var: 2
prefer-const: 2

# Custom rules in tools/eslint-rules
prefer-assert-iferror: 2
prefer-assert-methods: 2
## common module is mandatory in tests
required-modules: [2, common]