Skip to content

http: remove pointless uses of arguments #10664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjihrig merged 2 commits into from
Jan 10, 2017
+49 −56
Merged

http: remove pointless uses of arguments #10664

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a73ab9d
http: remove pointless use of arguments
cjihrig Jan 10, 2017
2d2a059
test: refactor test-http-mutable-headers.js
cjihrig Jan 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http: remove pointless use of arguments 
PR-URL: #10664
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@cjihrig
cjihrig committed Jan 10, 2017
commit a73ab9de0dfd1d62c429263c68640388e88fe847
8 changes: 4 additions & 4 deletions lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,8 @@ OutgoingMessage.prototype.setHeader = function setHeader(name, value) {


OutgoingMessage.prototype.getHeader = function getHeader(name) {
if (arguments.length < 1) {
throw new Error('"name" argument is required for getHeader(name)');
if (typeof name !== 'string') {
throw new TypeError('"name" argument must be a string');
}

if (!this._headers) return;
Expand All @@ -393,8 +393,8 @@ OutgoingMessage.prototype.getHeader = function getHeader(name) {


OutgoingMessage.prototype.removeHeader = function removeHeader(name) {
if (arguments.length < 1) {
throw new Error('"name" argument is required for removeHeader(name)');
if (typeof name !== 'string') {
throw new TypeError('"name" argument must be a string');
}

if (this._header) {
Expand Down