Skip to content

http: improve ClientRequest constructor #10654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscdex merged 6 commits into from
Jan 13, 2017
Merged

http: improve ClientRequest constructor #10654

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c2ef14
http: optimize short path validation
mscdex Jan 6, 2017
dab22b5
http: optimize default method case
mscdex Jan 6, 2017
15c6187
http: avoid duplicate isArray()
mscdex Jan 6, 2017
2f77596
http: misc ClientRequest cleanup
mscdex Jan 6, 2017
c5d0fd9
benchmark: add ClientRequest creation benchmark
mscdex Jan 6, 2017
57e2ec4
test: add http.ClientRequest defaults test
mscdex Jan 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: avoid duplicate isArray() 
PR-URL: #10654
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
  • Loading branch information
@mscdex
mscdex committed Jan 13, 2017
commit 15c6187aa5bacbf8cf2d71b4d93c0a4341e1a43e
5 changes: 3 additions & 2 deletions lib/_http_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ function ClientRequest(options, cb) {
self.once('response', cb);
}

if (!Array.isArray(options.headers)) {
var headersArray = Array.isArray(options.headers);
if (!headersArray) {
if (options.headers) {
var keys = Object.keys(options.headers);
for (var i = 0, l = keys.length; i < l; i++) {
Expand Down Expand Up @@ -168,7 +169,7 @@ function ClientRequest(options, cb) {
self.useChunkedEncodingByDefault = true;
}

if (Array.isArray(options.headers)) {
if (headersArray) {
self._storeHeader(self.method + ' ' + self.path + ' HTTP/1.1\r\n',
options.headers);
} else if (self.getHeader('expect')) {
Expand Down