Skip to content

Test revisions #10551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DavidGoussev wants to merge 4 commits into from
Closed

Test revisions #10551

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a26d602
test: remove process.on('exit') with callback wrapper common.mustCall
DavidGoussev Dec 31, 2016
fd8fa5b
test: remove process.on('exit') with callback wrapper common.mustCall
DavidGoussev Dec 31, 2016
15a48bc
test: implement callback wrapper common.mustCall
DavidGoussev Dec 31, 2016
b550a8c
test: refactor test-stream2-readable-wrap.js
DavidGoussev Dec 31, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: refactor test-stream2-readable-wrap.js
  • Loading branch information
@DavidGoussev
DavidGoussev committed Dec 31, 2016
commit b550a8ce157a7fd9e7b3f91fa8884a33a0bb6337
32 changes: 10 additions & 22 deletions test/parallel/test-stream2-readable-wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
require('../common');

const common = require('../common');
const assert = require('assert');
const Readable = require('_stream_readable');
const Writable = require('_stream_writable');
Expand All @@ -10,22 +9,17 @@ function runTest(highWaterMark, objectMode, produce) {

const old = new EE();
const r = new Readable({ highWaterMark: highWaterMark,
objectMode: objectMode });
objectMode: objectMode });
assert.strictEqual(r, r.wrap(old));

let ended = false;
r.on('end', common.mustCall(function() {
ended = true;
}));
r.on('end', common.mustCall(function() {}));

old.pause = function() {
console.error('old.pause()');
old.emit('pause');
flowing = false;
};

old.resume = function() {
console.error('old.resume()');
old.emit('resume');
flow();
};
Expand All @@ -39,24 +33,20 @@ function runTest(highWaterMark, objectMode, produce) {
while (flowing && chunks-- > 0) {
const item = produce();
expected.push(item);
console.log('old.emit', chunks, flowing);
old.emit('data', item);
console.log('after emit', chunks, flowing);
}
if (chunks <= 0) {
oldEnded = true;
console.log('old end', chunks, flowing);
old.emit('end');
}
}

const w = new Writable({ highWaterMark: highWaterMark * 2,
objectMode: objectMode });
const w = new Writable({ highWaterMark: highWaterMark * 2,
objectMode: objectMode });
const written = [];
w._write = function(chunk, encoding, cb) {
console.log('_write', chunk);
written.push(chunk);
setTimeout(cb, 1000);
setTimeout(cb, 1);
};

w.on('finish', common.mustCall(function() {
Expand All @@ -68,16 +58,14 @@ function runTest(highWaterMark, objectMode, produce) {
flow();

function performAsserts() {
assert(ended);
assert(oldEnded);
assert.deepStrictEqual(written, expected);
}
}

runTest(100, false, common.mustCall(function() { return Buffer.allocUnsafe(100); });
runTest(10, false, common.mustCall(function() { return Buffer.from('xxxxxxxxxx'); }));
runTest(1, true, common.mustCall(function() { return { foo: 'bar' }; }));
runTest(100, false, function() { return Buffer.allocUnsafe(100); });
runTest(10, false, function() { return Buffer.from('xxxxxxxxxx'); });
runTest(1, true, function() { return { foo: 'bar' }; });

const objectChunks = [ 5, 'a', false, 0, '', 'xyz', { x: 4 }, 7, [], 555 ];
runTest(1, true, common.mustCall(function() { return objectChunks.shift(); }));

runTest(1, true, function() { return objectChunks.shift(); });