Skip to content

test: refactor several parallel/test-timer tests #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BethGriggs wants to merge 2 commits into from
Closed

test: refactor several parallel/test-timer tests #10524

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d2a771
test: refactor several parallel/test-timer tests
BethGriggs Dec 29, 2016
ff0f0c8
fixup! test: refactor several parallel/test-timer tests
BethGriggs Jan 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: refactor several parallel/test-timer tests
  • Loading branch information
@BethGriggs
BethGriggs committed Jan 3, 2017
commit ff0f0c8e60ac7335181a1db536d68c2dea51c492
8 changes: 2 additions & 6 deletions test/parallel/test-timers-uncaught-exception.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,13 @@ const errorMsg = 'BAM!';
// the first timer throws...
setTimeout(common.mustCall(function() {
throw new Error(errorMsg);
}), 100);
}), 1);

// ...but the second one should still run
setTimeout(common.mustCall(function() {}), 100);
setTimeout(common.mustCall(function() {}), 1);

function uncaughtException(err) {
assert.strictEqual(err.message, errorMsg);
}

process.on('uncaughtException', common.mustCall(uncaughtException));

process.on('exit', function() {
process.removeListener('uncaughtException', uncaughtException);
});