Skip to content

test: refactor test-stream-pipe-after-end #10483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: refactor test-stream-pipe-after-end #10483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-stream-pipe-after-end 
* replace `process.on('exit', ...)` checks with `common.mustCall()`
* assert.equal() -> assert.strictEqual()
* provide duration of 1ms to timer without a duration
* remove unused function argument
  • Loading branch information
@Trott
Trott committed Dec 28, 2016
commit c9165c109e6e6286e62a5613b6195379eb87f4e8
27 changes: 7 additions & 20 deletions test/parallel/test-stream-pipe-after-end.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');
const Readable = require('_stream_readable');
const Writable = require('_stream_writable');
Expand All @@ -13,7 +13,7 @@ function TestReadable(opt) {
this._ended = false;
}

TestReadable.prototype._read = function(n) {
TestReadable.prototype._read = function() {
if (this._ended)
this.emit('error', new Error('_read called twice'));
this._ended = true;
Expand All @@ -35,31 +35,18 @@ TestWritable.prototype._write = function(chunk, encoding, cb) {

// this one should not emit 'end' until we read() from it later.
const ender = new TestReadable();
let enderEnded = false;

// what happens when you pipe() a Readable that's already ended?
const piper = new TestReadable();
// pushes EOF null, and length=0, so this will trigger 'end'
piper.read();

setTimeout(function() {
ender.on('end', function() {
enderEnded = true;
});
assert(!enderEnded);
setTimeout(common.mustCall(function() {
ender.on('end', common.mustCall(function() {}));
const c = ender.read();
assert.equal(c, null);
assert.strictEqual(c, null);

const w = new TestWritable();
let writableFinished = false;
w.on('finish', function() {
writableFinished = true;
});
w.on('finish', common.mustCall(function() {}));
piper.pipe(w);

process.on('exit', function() {
assert(enderEnded);
assert(writableFinished);
console.log('ok');
});
});
}, 1));