Skip to content

test: fix flaky test-http-client-timeout-event #10293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: fix flaky test-http-client-timeout-event #10293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-http-client-timeout-event 
Race condition caused occasional failure on CI. Chained callbacks used
to remove race condition.
  • Loading branch information
@Trott
Trott committed Dec 15, 2016
commit 93bbad38614af8363eb81b846c9c959e5bf99d0e
23 changes: 10 additions & 13 deletions test/parallel/test-http-client-timeout-event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,30 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');

var options = {
const options = {
method: 'GET',
port: undefined,
host: '127.0.0.1',
path: '/'
};

var server = http.createServer();
const server = http.createServer();

server.listen(0, options.host, function() {
options.port = this.address().port;
var req = http.request(options);
const req = http.request(options);
req.on('error', function() {
// this space is intentionally left blank
});
req.on('close', common.mustCall(() => server.close()));

var timeout_events = 0;
req.setTimeout(1);
req.on('timeout', common.mustCall(() => timeout_events += 1));
setTimeout(function() {
req.destroy();
assert.strictEqual(timeout_events, 1);
}, common.platformTimeout(100));
setTimeout(function() {
req.end();
}, common.platformTimeout(50));
req.on('timeout', common.mustCall(() => {
req.end(() => {
setTimeout(() => {
req.destroy();
}, 100);
});
}));
});