Skip to content

assert: enforce type check in deepStrictEqual #10282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 2 commits into from
Closed

assert: enforce type check in deepStrictEqual #10282

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3efc514
assert: enforce type check in deepStrictEqual
joyeecheung Jan 31, 2017
b8ed11b
add missing link, fix typo
joyeecheung Mar 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add missing link, fix typo
  • Loading branch information
@joyeecheung
joyeecheung committed Mar 12, 2017
commit b8ed11bbe99faa45f482deaf8e7bf39bbcf4c69b
5 changes: 3 additions & 2 deletions doc/api/assert.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ assert.deepStrictEqual({a: 1}, {a: '1'});
// AssertionError: { a: 1 } deepStrictEqual { a: '1' }
// because 1 !== '1' using strict equality

// The following objects don't have owned properties
// The following objects don't have own properties
const date = new Date();
const object = {};
const fakeDate = {};
Expand Down Expand Up @@ -599,4 +599,5 @@ For more information, see
[SameValueZero]: https://tc39.github.io/ecma262/#sec-samevaluezero
[prototype-spec]: https://tc39.github.io/ecma262/#sec-ordinary-object-internal-methods-and-internal-slots
[mdn-equality-guide]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Equality_comparisons_and_sameness
[enumerable "own" properties]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Enumerability_and_ownership_of_properties
[enumerable "own" properties]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Enumerability_and_ownership_of_properties
[Object.prototype.toString()]: https://tc39.github.io/ecma262/#sec-object.prototype.tostring