Skip to content

test: improve test-child-process-fork-and-spawn #10273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edsadr wants to merge 1 commit into from
Closed

test: improve test-child-process-fork-and-spawn #10273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: improve test-child-process-fork-and-spawn 
* use const instead of var for required modules
* use assert.strictEqual instead of assert.equal
* remove unnecessary process.nextTick
  • Loading branch information
@edsadr
edsadr committed Dec 17, 2016
commit 8a4bc9e471eb52c84ded2bdc3ef6e8bd00605757
11 changes: 5 additions & 6 deletions test/parallel/test-child-process-fork-and-spawn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
const common = require('../common');
var assert = require('assert');
var spawn = require('child_process').spawn;
var fork = require('child_process').fork;
const assert = require('assert');
const spawn = require('child_process').spawn;
const fork = require('child_process').fork;

// Fork, then spawn. The spawned process should not hang.
switch (process.argv[2] || '') {
Expand All @@ -16,10 +16,9 @@ switch (process.argv[2] || '') {
case 'spawn':
break;
default:
assert(0);
common.fail();
}

function checkExit(statusCode) {
assert.equal(statusCode, 0);
process.nextTick(process.exit);
assert.strictEqual(statusCode, 0);
}