Skip to content

test: refactor test-fs-read-stream-inherit #10246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

test: refactor test-fs-read-stream-inherit #10246

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3784361
test: refactor test-fs-read-stream-inherit
Trott Dec 13, 2016
cbceb8d
squash: moar common.mustCall()
Trott Dec 13, 2016
c5cf4ed
squash: nits from targos
Trott Dec 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: moar common.mustCall()
  • Loading branch information
@Trott
Trott committed Dec 14, 2016
commit cbceb8dde9eed7a0589145429a833f02080c9109
28 changes: 14 additions & 14 deletions test/parallel/test-fs-read-stream-inherit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ let paused = false;
file4.on('data', function(data) {
contentRead += data.toString('utf-8');
});
file4.on('end', function() {
file4.on('end', common.mustCall(function() {
assert.strictEqual(contentRead, 'yz');
});
}));
}

{
Expand All @@ -91,9 +91,9 @@ let paused = false;
file5.on('data', function(data) {
file5.data += data.toString('utf-8');
});
file5.on('end', function() {
file5.on('end', common.mustCall(function() {
assert.strictEqual(file5.data, 'yz\n');
});
}));
}

// https://github.com/joyent/node/issues/2320
Expand All @@ -105,9 +105,9 @@ let paused = false;
file6.on('data', function(data) {
file6.data += data.toString('utf-8');
});
file6.on('end', function() {
file6.on('end', common.mustCall(function() {
assert.strictEqual(file6.data, 'yz\n');
});
}));
}

{
Expand All @@ -127,9 +127,9 @@ let paused = false;
stream.data += chunk;
});

stream.on('end', function() {
stream.on('end', common.mustCall(function() {
assert.strictEqual(stream.data, 'x');
});
}));
}

// pause and then resume immediately.
Expand All @@ -144,13 +144,13 @@ let paused = false;
fs.createReadStream(rangeFile, Object.create({autoClose: false }));
assert.strictEqual(file7.autoClose, false);
file7.on('data', function() {});
file7.on('end', function() {
process.nextTick(function() {
file7.on('end', common.mustCall(function() {
process.nextTick(common.mustCall(function() {
assert(!file7.closed);
assert(!file7.destroyed);
file7Next();
});
});
}));
}));

function file7Next() {
// This will tell us if the fd is usable again or not.
Expand All @@ -159,9 +159,9 @@ let paused = false;
file7.on('data', function(data) {
file7.data += data;
});
file7.on('end', function() {
file7.on('end', common.mustCall(function() {
assert.strictEqual(file7.data, 'xyz\n');
});
}));
}
process.on('exit', function() {
assert(file7.closed);
Expand Down