Skip to content

test: refactor test-http-dns-fail #10243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edsadr wants to merge 1 commit into from
Closed

test: refactor test-http-dns-fail #10243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-http-dns-fail 
* remove counter used to control function execution
* use commont.mustCall to control the function execution
* use const and let instead of var
* use arrow functions
  • Loading branch information
@edsadr
edsadr committed Dec 12, 2016
commit db029f2ab738592f97725909919b98a6e8e6c14c
21 changes: 6 additions & 15 deletions test/internet/test-http-dns-fail.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,34 +5,25 @@
*/

const common = require('../common');
var assert = require('assert');
var http = require('http');

var hadError = 0;
const assert = require('assert');
const http = require('http');

function httpreq(count) {
if (1 < count) return;
if (count > 1) return;

var req = http.request({
const req = http.request({
host: 'not-a-real-domain-name.nobody-would-register-this-as-a-tld',
port: 80,
path: '/',
method: 'GET'
}, common.fail);

req.on('error', function(e) {
console.log(e.message);
req.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'ENOTFOUND');
hadError++;
httpreq(count + 1);
});
}));

req.end();
}

httpreq(0);


process.on('exit', function() {
assert.equal(2, hadError);
});