Skip to content

doc: clarify the review and landing process #10202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 10 commits into from
Closed

doc: clarify the review and landing process #10202

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cc22d35
doc: clarify the review and landing process
joyeecheung Dec 9, 2016
e8153b7
doc: clarify the landing process
joyeecheung Dec 11, 2016
0bb76ba
doc: explain the waiting time of semver-major PRs
joyeecheung Dec 13, 2016
32ab27a
doc: put the notes and details in the back
joyeecheung Dec 14, 2016
9bda4a4
doc: improve the clarification
joyeecheung Dec 15, 2016
dbd83ef
doc: more fixes about the process
joyeecheung Dec 15, 2016
96e0189
doc: amends the contributing guide
joyeecheung Dec 16, 2016
246f52a
doc: testing docs, PR history preservation
joyeecheung Dec 16, 2016
e9c53f3
doc: fix typo
joyeecheung Dec 20, 2016
41e4e93
doc: trim trailling spaces
joyeecheung Dec 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: trim trailling spaces
  • Loading branch information
@joyeecheung
joyeecheung committed Dec 22, 2016
commit 41e4e935ec5fbc640ce6ff368d01f70cc1d19e79
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ always pass when each individual commit lands on the master branch.
### Getting Approvals for Your Pull Request

A Pull Request is approved either by saying LGTM, which stands for
"Looks Good To Me", or by using GitHub's Approve button.
"Looks Good To Me", or by using GitHub's Approve button.
GitHub's Pull Request review feature can be used during the process.
For more information, check out
[the video tutorial](https://www.youtube.com/watch?v=HW0RPaJqm4g)
Expand All @@ -311,7 +311,7 @@ If not, you can ask a Collaborator to request a CI run.

A Pull Request needs to stay open for at least 48 hours (72 hours on a
weekend) from when it is submitted, even after it gets approved and
passes the CI. This is to make sure that everyone has a chance to
passes the CI. This is to make sure that everyone has a chance to
weigh in. If the changes are trivial, collaborators may decide it
doesn't need to wait. A Pull Request may well take longer to be
merged in. All these precautions are important because Node.js is
Expand Down