Skip to content

buffer: removed unused variable conf from buffer-base64-decode & buffer-base64-encode #10175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
troy0820 wants to merge 4 commits into from
Closed

buffer: removed unused variable conf from buffer-base64-decode & buffer-base64-encode #10175

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7243066
buffer: Add array in createBenchmark object for buffer size & iterati…
troy0820 Dec 7, 2016
4eb18d6
buffer: Change n to len and added + to ensure it is a number
troy0820 Dec 8, 2016
df392f0
buffer: Changed N to len and len back to n
troy0820 Dec 8, 2016
08cdc9c
buffer: changed N to len and replaced all N to len
troy0820 Dec 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
buffer: Add array in createBenchmark object for buffer size & iterati… 
…on in buffer-base64-encode & buffer-base64-decode.js
  • Loading branch information
@troy0820 @Trott
troy0820 authored and Trott committed Dec 23, 2016
commit 7243066bebf1d27d8d7ad7e89e130fecbd60ebac
9 changes: 6 additions & 3 deletions benchmark/buffers/buffer-base64-decode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,18 @@
const assert = require('assert');
const common = require('../common.js');

const bench = common.createBenchmark(main, {});
const bench = common.createBenchmark(main, {
n: [32],
});

function main(conf) {
const n = conf.n;
Copy link
Copy Markdown
Contributor

@mscdex mscdex Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be +conf.n.

const s = 'abcd'.repeat(8 << 20);
s.match(/./); // Flatten string.
assert.strictEqual(s.length % 4, 0);
const b = Buffer.allocUnsafe(s.length / 4 * 3);
b.write(s, 0, s.length, 'base64');
bench.start();
for (var i = 0; i < 32; i += 1) b.base64Write(s, 0, s.length);
bench.end(32);
for (var i = 0; i < n; i += 1) b.base64Write(s, 0, s.length);
bench.end(n);
}
12 changes: 8 additions & 4 deletions benchmark/buffers/buffer-base64-encode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,20 @@
'use strict';
var common = require('../common.js');

var bench = common.createBenchmark(main, {});
const bench = common.createBenchmark(main, {
N: [64 * 1024 * 1024],
Copy link
Copy Markdown
Contributor

@mscdex mscdex Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to give this a better name to avoid confusion. I think other benchmarks use names like len, which I would be fine with.

n: [32]
});

function main(conf) {
var N = 64 * 1024 * 1024;
var n = conf.n;
var N = conf.N;
Copy link
Copy Markdown
Contributor

@mscdex mscdex Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly for these, the values should be prefixed with + to ensure they are numbers.

var b = Buffer.allocUnsafe(N);
var s = '';
var i;
for (i = 0; i < 256; ++i) s += String.fromCharCode(i);
for (i = 0; i < N; i += 256) b.write(s, i, 256, 'ascii');
bench.start();
for (i = 0; i < 32; ++i) b.toString('base64');
bench.end(64);
for (i = 0; i < n; ++i) b.toString('base64');
bench.end(n);
Copy link
Copy Markdown
Member

@jasnell jasnell Dec 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the change from 64 to 32 in the bench.end(n) here intentional?

Copy link
Copy Markdown
Member

@jasnell jasnell Dec 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind... just spotted the other comment about it :-)

}