Skip to content

url: build warning fixes #10141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brody2consult wants to merge 2 commits into from
Closed

url: build warning fixes #10141

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5906faa
url: mark ignored return value in node::url::Parse(...)
Nov 23, 2016
9695066
url: use URL_FAILED instead of FAILED macro
Dec 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
url: mark ignored return value in node::url::Parse(...) 
This is to resolve an unused result warning in node_url.cc.
  • Loading branch information
Christopher J. Brody committed Dec 6, 2016
commit 5906faaba4d3f575fe8bec7406e0488a0e22fdbb
2 changes: 1 addition & 1 deletion src/node_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,7 +1294,7 @@ namespace url {
argv[ARG_PATH] = Copy(isolate, url.path);
}

cb->Call(context, recv, 9, argv);
(void)cb->Call(context, recv, 9, argv);
}

static void Parse(const FunctionCallbackInfo<Value>& args) {
Expand Down