lib,src: make process global non-writable

nodejs · bnoordhuis · Dec 5, 2016 · Dec 11, 2016 · Dec 11, 2016 · 54aec1efeecefe44f3589de699ff82a43738f989
commit 54aec1efeecefe44f3589de699ff82a43738f989
diff --git a/lib/internal/bootstrap_node.js b/lib/internal/bootstrap_node.js
@@ -7,9 +7,13 @@
 
 'use strict';
 
-(function(process) {
+(function(global, process) {
+
+  function startup(global, process) {
+    // Expose the global object as a property on itself
+    // (Allows you to set stuff on `global` from anywhere in JavaScript.)
+    global.global = global;
 
-  function startup() {
     const EventEmitter = NativeModule.require('events');
     process._eventsCount = 0;
 
@@ -196,7 +200,12 @@
       enumerable: false,
       configurable: true
     });
-    global.process = process;
+    Object.defineProperty(global, 'process', {
+      value: process,
+      writable: false,
+      enumerable: true,
+      configurable: true
+    });
     const util = NativeModule.require('util');
 
     // Deprecate GLOBAL and root
@@ -532,5 +541,5 @@
     NativeModule._cache[this.id] = this;
   };
 
-  startup();
+  startup(global, process);
 });
diff --git a/src/node.cc b/src/node.cc
@@ -3441,19 +3441,15 @@ void LoadEnvironment(Environment* env) {
 
   env->SetMethod(env->process_object(), "_rawDebug", RawDebug);
 
-  // Expose the global object as a property on itself
-  // (Allows you to set stuff on `global` from anywhere in JavaScript.)
-  global->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "global"), global);
-
   // Now we call 'f' with the 'process' variable that we've built up with
   // all our bindings. Inside bootstrap_node.js and internal/process we'll
   // take care of assigning things to their places.
 
   // We start the process this way in order to be more modular. Developers
   // who do not like how bootstrap_node.js sets up the module system but do
   // like Node's I/O bindings may want to replace 'f' with their own function.
-  Local<Value> arg = env->process_object();
-  f->Call(Null(env->isolate()), 1, &arg);
+  Local<Value> argv[] = { global, env->process_object() };
+  f->Call(Null(env->isolate()), arraysize(argv), argv);
 }
 
 static void PrintHelp() {

diff --git a/test/parallel/test-process-clobber.js b/test/parallel/test-process-clobber.js
@@ -1,5 +1,7 @@
 /* eslint-disable no-global-assign */
-/* eslint-disable required-modules */
 'use strict';
 
-process = null;  // Should not bring down program.
+require('../common');
+const assert = require('assert');
+
+assert.throws(() => process = null, /Cannot assign to read only property/);