Skip to content

debugger: call this.resume() after this.run() #10099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lance wants to merge 4 commits into from
Closed

debugger: call this.resume() after this.run() #10099

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7821d02
debugger: call `this.resume()` after `this.run()`
lance Dec 2, 2016
cce1225
debugger: fix linting issues
lance Dec 3, 2016
2909c6a
debugger: Add a test for 'debug> ' prompt.
lance Dec 5, 2016
a8752ec
debugger: remove unnecessary timer from a test
lance Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
debugger: Add a test for 'debug> ' prompt.
  • Loading branch information
@lance
lance committed Dec 5, 2016
commit 2909c6a7f924c8126ee5fb114c6ff48a4c9296eb
18 changes: 18 additions & 0 deletions test/parallel/test-debug-prompt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';

const assert = require('assert');
const common = require('../common');
const spawn = require('child_process').spawn;

const timeoutId = setTimeout(function() {
Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the timeout needed? Couldn't we just let the test timeout and fail instead of introducing a timer?

Copy link
Copy Markdown
Member Author

@lance lance Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it is redundant. I was just modeling off of another test that spawns a node process.

Copy link
Copy Markdown
Contributor

@cjihrig cjihrig Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, if you don't need it, I'd remove it. They add complexity to the code and timers have been a source of annoyance on the CI.

common.fail('test-debug-prompt timeout failure');
}, common.platformTimeout(5000));

const proc = spawn(process.execPath, ['debug', 'foo']);
proc.stdout.setEncoding('utf8');

proc.stdout.once('data', common.mustCall((data) => {
clearTimeout(timeoutId);
assert.strictEqual(data, 'debug> ');
proc.kill();
}));