Skip to content

fs: copyObject() had unused argument #10041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ethan-Arrowood wants to merge 1 commit into from
Closed

fs: copyObject() had unused argument #10041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fs: copyObject() had unused argument: target 
The fs function copyObject() had two arguments:
source and target. On the first line of the function it
assigned the target variable to:
arguments.length >= 2 ? target : {};

The function copyObject() was not called directly by
any test, but it is called in other fs functions. When it
was called it was only ever called with a single argument,
source. Thus I have removed the target argument and assigned
it to an empty object like it was being assigned to in the
original ternary operator.
  • Loading branch information
@Ethan-Arrowood
Ethan-Arrowood committed Dec 1, 2016
commit 92a4bb8c152328fa7a9fc95b38c1e8853c4d2f4b
4 changes: 2 additions & 2 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ function getOptions(options, defaultOptions) {
return options;
}

function copyObject(source, target) {
target = arguments.length >= 2 ? target : {};
function copyObject(source) {
const target = {};
for (const key in source)
target[key] = source[key];
return target;
Expand Down