Skip to content

test: add test for url module domainToAscii and domainToUnicode #10031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DarylThayil wants to merge 3 commits into from
Closed

test: add test for url module domainToAscii and domainToUnicode #10031

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82cc3f9
test: add test for url module domainToAscii and domainToUnicode
darylthayilporch Dec 1, 2016
d5279d9
Update test-url-domain-ascii-unicode.js
DarylThayil Dec 5, 2016
724234a
Update test-url-domain-ascii-unicode.js
DarylThayil Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add test for url module domainToAscii and domainToUnicode
  • Loading branch information
@darylthayilporch
darylthayilporch committed Dec 1, 2016
commit 82cc3f9aadb695fbc474741fead2fbcf8ba8fa7d
27 changes: 27 additions & 0 deletions test/parallel/test-url-domain-ascii-unicode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';

require('../common');
const strictEqual = require('assert').strictEqual;
const url = require('url');

const domainToASCII = url.URL.domainToASCII;
const domainToUnicode = url.URL.domainToUnicode;

const domainWithASCII = [
['ıídيٴ', 'xn--d-iga7ro0q9f'],
['www.ϧƽəʐ.com', 'www.xn--cja62apfr6c.com'],
['новини.com', 'xn--b1amarcd.com'],
['名がドメイン.com', 'xn--v8jxj3d1dzdz08w.com'],
['افغانستا.icom.museum', 'xn--mgbaal8b0b9b2b.icom.museum'],
['الجزائر.icom.fake', 'xn--lgbbat1ad8j.icom.fake'],
['भारत.org', 'xn--h2brj9c.org']
];

domainWithASCII.forEach(pair => {
Copy link
Copy Markdown
Member

@jasnell jasnell Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap the pair in parens to match the common style

const domain = pair[0];
const ascii = pair[1];
const domainConvertedToASCII = domainToASCII(domain);
strictEqual(domainConvertedToASCII, ascii);
const asciiConvertedToUnicode = domainToUnicode(ascii);
strictEqual(asciiConvertedToUnicode, domain);
});