fix: include climits to fix build - #50
Closed
ndossche wants to merge 1 commit into
Closed
Conversation
Fixes the following build failure:
```
/home/nora/ncrypto/src/ncrypto.cpp: In function ‘bool ncrypto::CSPRNG(void*, size_t)’:
/home/nora/ncrypto/src/ncrypto.cpp:602:23: error: ‘INT_MAX’ was not declared in this scope
602 | while (length > INT_MAX && 1 == RAND_bytes(buf, INT_MAX)) {
| ^~~~~~~
```
Member
|
I think these changes out to land on the Node.js side of things first. |
Contributor
Author
|
Okay I will, but it's confusing as I'm pretty sure in the past I've been told to send them here first |
Member
|
Right, we are now simply syncing the ncrypto state from nodejs/node in here. So if the change is only relevant to downstream consumers of this repo it's fine for it to be here directly, otherwise it should go to nodejs/node. The source for nodejs/node remains there. |
Contributor
Author
|
Seems like this particular fix is already included in #51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following build failure:
On
g++ (GCC) 16.1.1 20260728on Linux