Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

Table source type detection #465

Merged
GeoffreyBooth merged 1 commit into from
Jan 15, 2020
Merged

Table source type detection #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Table detection
  • Loading branch information
@GeoffreyBooth
GeoffreyBooth committed Jan 12, 2020
commit f30843bafdbc5925c50e5a74027458903ef6bd2a
2 changes: 1 addition & 1 deletion doc/plan-for-new-modules-implementation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Phase 3 improves user experience and extends the MVP. Phase 3 is malleable based
* Limited module type detection.
- PR: https://github.com/nodejs/ecmascript-modules/pull/69.
- Upstream PR: https://github.com/nodejs/node/pull/27808.
- **Status**: Upstream PR submitted.
- **Tabled**. The group’s current thinking is to encourage explicit source type definition via file extension or the `"type"` field. Source type detection via parsing source code is not 100% accurate and should therefore be left to userland where users can choose to accept its risks.

* Provide a way to make ESM the default instead of CommonJS.
- Discussion: https://github.com/nodejs/modules/issues/318.
Expand Down