Skip to content

src: fix JSError inspection #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 2 commits into from
Closed

src: fix JSError inspection #215

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22588cc
src: fix JSError inspection
Jul 16, 2018
6fdfd26
fixup! src: fix JSError inspection
Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: fix JSError inspection
  • Loading branch information
@mmarchini
Matheus Marchini authored and mmarchini committed Sep 11, 2018
commit 6fdfd26a5b94067d3617c8ac231fb063374ad232
19 changes: 18 additions & 1 deletion test/plugin/inspect-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,24 @@ const hashMapTests = {
// .error=0x0000392d5d661119:<Object: Error>

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

'error': {
re: /.error=(0x[0-9a-f]+):<Object: Error>/,
desc: '.error Error property'
desc: '.error Error property',
validator(t, sess, addresses, name, cb) {
const address = addresses[name];
sess.send(`v8 inspect ${address}`);

sess.linesUntil(/}>/, (err, lines) => {
if (err) return cb(err);
lines = lines.join('\n');

let codeMatch = lines.match(/code=(0x[0-9a-f]+):<String: "ERR_TEST">/i);
t.ok(codeMatch, 'hashmap.error.code should be "ERR_TEST"');

let errnoMatch = lines.match(/errno=<Smi: 1>/i);
t.ok(errnoMatch, 'hashmap.error.errno should be 1');

cb(null);
});
}
},
// .array=0x000003df9cbe7919:<Array: length=6>,
'array': {
Expand Down