Skip to content

test: update travis config, handle errors properly, add TEST_LLNODE_DEBUG #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joyeecheung merged 5 commits into from
Nov 30, 2017
Merged

test: update travis config, handle errors properly, add TEST_LLNODE_DEBUG #144

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2155954
travis: test node 4, 6, 8, 9 with lldb-3.9
joyeecheung Nov 28, 2017
b36fbc0
test: show lldb output when timing out
joyeecheung Nov 3, 2017
ecd9eec
test: proper error-first handling
joyeecheung Nov 28, 2017
f7a4ed3
travis: show debug output in CI
joyeecheung Nov 28, 2017
ae83fe8
test: add containsLine function
joyeecheung Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add containsLine function
  • Loading branch information
@joyeecheung
joyeecheung committed Nov 29, 2017
commit ae83fe8384fb37f6039b4fe2c9f07c3e852727e9
13 changes: 8 additions & 5 deletions test/usage-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
const tape = require('tape');
const common = require('./common');

function containsLine(lines, re) {
return lines.some(line => re.test(line.trim()));
}

tape('usage messages', (t) => {
t.timeoutAfter(15000);

Expand All @@ -15,29 +19,28 @@ tape('usage messages', (t) => {
sess.stderr.linesUntil(/USAGE/, (err, lines) => {
t.error(err);
const re = /^error: USAGE: v8 print expr$/;
t.ok(lines.some(line => re.test(line.trim())), 'print usage message');
t.ok(containsLine(lines, re), 'print usage message');
sess.send('v8 source list');
});

sess.stderr.linesUntil(/USAGE/, (err, lines) => {
t.error(err);
const re = /^error: USAGE: v8 source list$/;
t.ok(lines.some(line => re.test(line.trim())), 'list usage message');
t.ok(containsLine(lines, re), 'list usage message');
sess.send('v8 findjsinstances');
});

sess.stderr.linesUntil(/USAGE/, (err, lines) => {
t.error(err);
const re = /^error: USAGE: v8 findjsinstances \[flags\] instance_name$/;
t.ok(lines.some(line => re.test(line.trim())),
'findjsinstances usage message');
t.ok(containsLine(lines, re), 'findjsinstances usage message');
sess.send('v8 findrefs');
});

sess.stderr.linesUntil(/USAGE/, (err, lines) => {
t.error(err);
const re = /^error: USAGE: v8 findrefs expr$/;
t.ok(lines.some(line => re.test(line.trim())), 'findrefs usage message');
t.ok(containsLine(lines, re), 'findrefs usage message');
sess.quit();
t.end();
});
Expand Down