Skip to content

fix: broken internal links#48

Merged
avivkeller merged 1 commit intomainfrom
fix/broken-internal-links
Apr 8, 2026
Merged

fix: broken internal links#48
avivkeller merged 1 commit intomainfrom
fix/broken-internal-links

Conversation

@canerakdas
Copy link
Copy Markdown
Member

As stated in the title, this PR updates the links that were leading to 404 pages on the edited pages with their correct versions.

Pages and links;

  • /learn/diagnostics/live-debugging/using-inspector
    • Debugging Node.js
  • /learn/diagnostics/poor-performance/index
    • Using V8 Sampling Profiler
  • /learn/getting-started/profiling
    • diagnostics flamegraph
  • /learn/getting-started/security-best-practices
    • --inspect switch
    • same-origin policy
  • /learn/modules/how-to-use-streams
    • backpressure guide

Copilot AI review requested due to automatic review settings April 8, 2026 17:29
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview Apr 8, 2026 5:29pm

Request Review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes broken internal documentation links that were returning 404s by updating them to the correct /learn/... routes that match the site’s configured base URL.

Changes:

  • Update “backpressure guide” reference link to the correct modules path.
  • Fix “Debugging Node.js”, profiling, and flame graph links to point at existing /learn/... pages.
  • Correct the “Using V8 Sampling Profiler” link target in the poor-performance index.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pages/modules/how-to-use-streams.md Updates the backpressure guide link to /learn/modules/backpressuring-in-streams.
pages/getting-started/security-best-practices.md Fixes --inspect switch and same-origin policy reference links to /learn/getting-started/debugging.
pages/getting-started/profiling.md Fixes flame graph link to /learn/diagnostics/flame-graphs.
pages/diagnostics/poor-performance/index.md Updates “Using V8 Sampling Profiler” link to /learn/getting-started/profiling.
pages/diagnostics/live-debugging/using-inspector.md Updates “Debugging Node.js” link to /learn/getting-started/debugging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit 1395086 Apr 8, 2026
10 checks passed
@avivkeller avivkeller deleted the fix/broken-internal-links branch April 8, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants