Skip to content

Fix module interception on windows#22

Merged
bengl merged 4 commits intonodejs:mainfrom
CarlesDD:ccapell/fix-module-details-on-windows
Sep 2, 2022
Merged

Fix module interception on windows#22
bengl merged 4 commits intonodejs:mainfrom
CarlesDD:ccapell/fix-module-details-on-windows

Conversation

@CarlesDD
Copy link
Copy Markdown
Contributor

@CarlesDD CarlesDD commented Sep 1, 2022

This PR fixes the bug that occurs in Windows where non-internal module loading is not intercepted due to the platform-specific path segment separator.

@CarlesDD CarlesDD changed the title Fix module details on windows Fix module interception on windows Sep 1, 2022
@CarlesDD CarlesDD marked this pull request as draft September 1, 2022 16:48
@CarlesDD CarlesDD marked this pull request as ready for review September 2, 2022 13:08
Comment thread .github/workflows/ci.yml
@bengl bengl merged commit 133e556 into nodejs:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants