fix: Incompatible with module.registerHooks#202
Closed
timokoessler wants to merge 3 commits intonodejs:mainfrom
Closed
fix: Incompatible with module.registerHooks#202timokoessler wants to merge 3 commits intonodejs:mainfrom
timokoessler wants to merge 3 commits intonodejs:mainfrom
Conversation
jsumners-nr
previously approved these changes
Jun 26, 2025
Co-authored-by: James Sumners <jsumners@newrelic.com>
jsumners-nr
approved these changes
Jun 26, 2025
Contributor
|
Happy to consider merging this if we can get the CI tests passing! |
Author
|
Unfortunately, this fix appears to cause problems with the module cache in Node.js in some cases. I have added a comment to the issue: nodejs/node#57327 (comment). |
Author
|
Closing as fixed in Node.js v25.1.0, see nodejs/node#59929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents that the load hook returns a nullish value for the source if a CJS module is loaded.
The reason for this is that Node.js will otherwise crash if the synchronous module customization hooks are used. See nodejs/node#57327 for more information. The Node.js documentation also mentions that returning nullish values might no longer be supported in the future in general.