Skip to content

feat: upgrade octokit to 16 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmarchini merged 7 commits into from
Aug 20, 2020
Merged

feat: upgrade octokit to 16 #282

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
948ee82
chore: test removeLabel
mmarchini Aug 15, 2020
3cf7cb6
chore: async createGhStatus
mmarchini Aug 15, 2020
618dda1
chore: async findLatestCommitInPr
mmarchini Aug 15, 2020
53a9277
chore: async resolveLabelsThenUpdatePr/listFiles
mmarchini Aug 15, 2020
9d733bd
chore: async removeLabels
mmarchini Aug 15, 2020
e7eada1
chore: promisified getBotPrLabels
mmarchini Aug 15, 2020
e29d587
feat: upgrade octokit to 16
mmarchini Aug 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: async createGhStatus
  • Loading branch information
@mmarchini
mmarchini committed Aug 15, 2020
commit 3cf7cb6af78674f10a8e729609e16523f8459176
36 changes: 17 additions & 19 deletions lib/push-jenkins-update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ function pushStarted (options, build, cb) {
message: build.message || 'running tests'
}, options)

createGhStatus(statusOpts, logger, cb)
createGhStatus(statusOpts, logger).then(cb).catch(cb)
})
}

Expand Down Expand Up @@ -109,24 +109,22 @@ function findLatestCommitInPr (options, cb, pageNumber = 1) {
})
}

function createGhStatus (options, logger, cb) {
githubClient.repos.createStatus({
owner: options.owner,
repo: options.repo,
sha: options.sha,
target_url: options.url,
context: options.context,
state: options.state,
description: options.message
}, (err, res) => {
if (err) {
logger.error(err, 'Error while updating Jenkins / GitHub PR status')
cb(err)
return
}
logger.info('Jenkins / Github PR status updated')
cb(null)
})
async function createGhStatus (options, logger) {
try {
await githubClient.repos.createStatus({
owner: options.owner,
repo: options.repo,
sha: options.sha,
target_url: options.url,
context: options.context,
state: options.state,
description: options.message
})
} catch (err) {
logger.error(err, 'Error while updating Jenkins / GitHub PR status')
throw err
}
logger.info('Jenkins / Github PR status updated')
}

function validate (payload) {
Expand Down