Skip to content

Use shell expansion when selecting which NODE_VERSION to build #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 5 commits into from
Jul 25, 2017
Merged

Use shell expansion when selecting which NODE_VERSION to build #322

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7dbb287
Use shell expansion when selecting which NODE_VERSION to build
Feb 1, 2017
daaf9f4
Call out which major.minor version is being tested
Feb 1, 2017
2e625b6
Merge branch 'master' into travis-shell-expansion
chorrell Jul 13, 2017
80200e0
Add trailing newline back
chorrell Jul 13, 2017
5b3185d
Merge branch 'master' into travis-shell-expansion
SimenB Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into travis-shell-expansion
  • Loading branch information
@chorrell
chorrell authored Jul 13, 2017
commit 2e625b629f33fa99d366db90157b84b2759ea139
19 changes: 15 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,18 @@ script:
fi

env:
matrix :
- NODE_VERSION: '4.*'
- NODE_VERSION: '6.*'
- NODE_VERSION: '7.*'
- DOCTOCCHECK: true
- NODE_VERSION: '4.*'
- NODE_VERSION: '6.*'
- NODE_VERSION: '7.*'
- NODE_VERSION: '8.*'

matrix:
include:
env: SHELLCHECK=true
addons:
apt:
sources:
- debian-sid
packages:
- shellcheck

This comment was marked as off-topic.

Sign in to view

3 changes: 1 addition & 2 deletions test-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ for version in "${versions[@]}"; do
# Skip "docs" and other non-docker directories
[ -f "$version/Dockerfile" ] || continue

info "### Testing $version ###"
tag=$(cat $version/Dockerfile | grep "ENV NODE_VERSION" | cut -d' ' -f3)
tag=$(grep "ENV NODE_VERSION" "$version/Dockerfile" | cut -d' ' -f3)

info "Building $tag..."

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.